fix: batch NFT ownership checks via Multicall3#8281
Merged
Conversation
7 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 09a4cdc. Configure here.
bergarces
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
AssetsContractControllermessenger calls (getERC721OwnerOf,getERC1155BalanceOf) with a newgetNftOwnershipForMultipleNftsutility that batches ERC-721ownerOfand ERC-1155balanceOfcalls through Multicall3'saggregate3, falling back to individual RPC calls on unsupported chains or when multicall fails.checkAndUpdateSingleNftOwnershipStatusin favor ofcheckAndUpdateAllNftsOwnershipStatus, which now batches all NFTs in a single pass.standardparameter toisNftOwnerso callers that already know the token standard skip redundant subcalls.checkAndUpdateAllNftsOwnershipStatusnow removes NFTs confirmed as unowned from state rather than retaining them withisCurrentlyOwned: false. The "Previously Owned" NFT feature this flag powered is no longer supported.Breaking Changes
checkAndUpdateSingleNftOwnershipStatusremoved — usecheckAndUpdateAllNftsOwnershipStatusinstead.AllowedActionsnarrowed —AssetsContractController:getERC721OwnerOfandAssetsContractController:getERC1155BalanceOfare no longer required byNftController's messenger. Consumers constructing the messenger must remove these from their allowed actions list.References
Ticket: https://consensyssoftware.atlassian.net/browse/ASSETS-2959
PR on Mobile: MetaMask/metamask-mobile#28655
PR on Extension:
Checklist
Note
Medium Risk
Medium risk due to breaking API surface (
AllowedActionsnarrowed,checkAndUpdateSingleNftOwnershipStatusremoved) and changed state semantics (unowned NFTs are deleted), plus new multicall batching logic that could affect ownership determination across networks.Overview
NFT ownership checks are refactored to batch on-chain calls via Multicall3.
NftController.isNftOwnerandcheckAndUpdateAllNftsOwnershipStatusnow use the newgetNftOwnershipForMultipleNftshelper to aggregate ERC-721ownerOf/ ERC-1155balanceOfcalls (with fallback to individual calls when multicall/chain support is unavailable), and callers can pass an optionalstandardto skip unnecessary subcalls.Breaking behavior changes:
AssetsContractController:getERC721OwnerOfandAssetsContractController:getERC1155BalanceOfare removed fromNftControllerAllowedActions,checkAndUpdateSingleNftOwnershipStatusis removed, and ownership refresh now removes NFTs confirmed as unowned from state instead of settingisCurrentlyOwned: false. Tests and changelog are updated accordingly, andmulticallgains comprehensive coverage for the new NFT ownership batching utility.Reviewed by Cursor Bugbot for commit f782f90. Bugbot is set up for automated code reviews on this repo. Configure here.